Merged
Conversation
khoshov
reviewed
May 29, 2025
| User = get_user_model() | ||
|
|
||
|
|
||
| class Publisher(models.Model): |
khoshov
reviewed
May 29, 2025
|
|
||
| class Publisher(models.Model): | ||
| name = models.CharField(max_length=255, verbose_name="Название издательства") | ||
| website = models.URLField( |
Owner
There was a problem hiding this comment.
Отформатировать порядок передачи аргументов
khoshov
reviewed
May 29, 2025
apps/books/models.py
Outdated
| return self.name | ||
|
|
||
|
|
||
| class Book(models.Model): |
Owner
There was a problem hiding this comment.
Вот несколько предложений по улучшению названий полей в модели Book:
author→authors(поскольку это ManyToManyField, лучше использовать множественное число)publication_date→published_at(более стандартное название для дат)isbn→isbn_code(более явное название)pages→page_countилиtotal_pages(более описательно)cover_image→cover_image_url(явнее указывает, что это URL)parsed_at→created_at(более стандартное название для времени создания)
Также можно рассмотреть:
description→summary(если это краткое описание)language→language_code(если хранится код языка)
Измененная модель могла бы выглядеть так:
class Book(models.Model):
authors = models.ManyToManyField(Author, related_name="books", verbose_name="Авторы")
publisher = models.ForeignKey(
Publisher,
on_delete=models.CASCADE,
related_name="books",
verbose_name="Издательство",
)
title = models.CharField(max_length=255, verbose_name="Название книги")
summary = models.TextField(verbose_name="Описание книги")
published_at = models.DateField(verbose_name="Дата публикации")
isbn_code = models.CharField(max_length=20, verbose_name="ISBN")
page_count = models.IntegerField(verbose_name="Количество страниц")
cover_image_url = models.URLField(max_length=255, verbose_name="Обложка книги")
language_code = models.CharField(max_length=50, verbose_name="Язык")
tags = models.ManyToManyField(Tag, related_name="books", verbose_name="Теги")
created_at = models.DateTimeField(auto_now_add=True, verbose_name="Дата создания")
class Meta:
verbose_name = "Книга"
verbose_name_plural = "Книги"
def __str__(self):
return self.titleЭти изменения делают названия более явными и соответствуют common conventions в Django.
khoshov
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.